ROX-21873: increase sensitivity on alert for tenant db connections #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes94
force-pushed
the
jmalsam/ROX-21873-db-connection-alert-threshold
branch
from
f665045 to
8257d73
Compare
stehessel
approved these changes
Jul 15, 2024
johannes94
added a commit
that referenced
this pull request
Jul 23, 2024
This reverts commit 67f7f4f.
johannes94
added a commit
that referenced
this pull request
Jul 23, 2024
aaa5kameric
pushed a commit
that referenced
this pull request
Aug 28, 2024
aaa5kameric
pushed a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested this alert as part of https://issues.redhat.com/browse/ROX-21873 by blocking DB ingress via AWS security groups.
It took 35 minutes for this alert to appear in alertmanager. This is because we're working with the AVG metric in this alert and have a wait time of 20 minutes defined. Since a broken DB connection means a critical state for the entire system I think we should alert earlier on this.
Looking at the metrics for longer running tenants it seems to make sense to continue using the AVG because on central rollouts this metric might be down for some time. So instead of increasing the threshold I reduced the wait time to 10 minutes.